addons: render addons as tasks#18215
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
size/XXL
|
Remove the noise, will fix separately. |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons, pull-kops-aws-upgrade-k134-ko134-to-kstable-kolatest-many-addons, pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-kops-e2e-k8s-aws-calico |
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
|
/override build-linux-amd64 |
|
@hakman: Overrode contexts on behalf of hakman: build-linux-amd64 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Defer addon manifest rendering and bootstrap-channel assembly into AddonManifest and BootstrapChannel fi-tasks so addon templates can reference the finalized task graph. Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
| if a == nil { | ||
| return nil | ||
| } | ||
| return &fitasks.ManagedFile{ |
|
Great stuff @hakman /approve /unhold |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Happy you like it 🙂 |
|
Unrelated flake... |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-cilium DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Defer addon manifest rendering and bootstrap-channel assembly into AddonManifest and BootstrapChannel fi-tasks so addon templates can reference the finalized task graph.
/cc @justinsb @rifelpet
/assign @justinsb
/hold for feedback